Issue 15383002: Use handles to save the object being read before calling StorePointer to make

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15383002: Use handles to save the object being read before calling StorePointer to make (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Use handles to save the object being read before calling StorePointer to make sure we are GC safe. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22889

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
	M	runtime/vm/object.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	runtime/vm/raw_object_snapshot.cc	View	1	8 chunks	+17 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

Ivan Posva

LGTM, but we should also address the problem in object.cc:6057 as outlined in issue 10709. ...

7 years, 7 months ago (2013-05-18 01:18:36 UTC) #2

siva

7 years, 7 months ago (2013-05-20 05:15:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22889 (presubmit successful).