Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153823007: Fix more warnings for dart:html. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix more warnings for dart:html. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32618

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -117 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 17 chunks +80 lines, -78 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 16 chunks +84 lines, -27 lines 0 comments Download
M sdk/lib/html/html_common/lists.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/dom.json View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/CrossFrameTypes.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/src/WrappedEvent.dart View 1 2 chunks +41 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_AbstractWorker.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +7 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
After this CL goes in, the only warnings left will be the ones we're waiting ...
6 years, 10 months ago (2014-02-11 21:39:31 UTC) #1
blois
lgtm https://codereview.chromium.org/153823007/diff/30001/tools/dom/src/EventStreamProvider.dart File tools/dom/src/EventStreamProvider.dart (right): https://codereview.chromium.org/153823007/diff/30001/tools/dom/src/EventStreamProvider.dart#newcode432 tools/dom/src/EventStreamProvider.dart:432: String get _eventType => throw new UnsupportedError('Access type ...
6 years, 10 months ago (2014-02-11 22:48:28 UTC) #2
Emily Fortuna
6 years, 10 months ago (2014-02-12 20:12:19 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r32618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698