Issue 15371008: dart:io | Roll third_party/nss from Chromium to revision 199075.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15371008: dart:io | Roll third_party/nss from Chromium to revision 199075. (Closed)

Created:
7 years, 7 months ago by Bill Hesse

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

dart:io | Roll third_party/nss from Chromium to revision 199075. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23019

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+957 lines, -936 lines)			Patch
M	dart/runtime/bin/net/nss.gyp	View	1 2	17 chunks	+852 lines, -814 lines	0 comments	Download
M	dart/runtime/bin/net/os_linux.S	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	dart/runtime/bin/net/sqlite.gyp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/runtime/bin/net/ssl.gyp	View	1 2	4 chunks	+27 lines, -3 lines	0 comments	Download
M	dart/runtime/bin/net/zlib.gyp	View	1 2	4 chunks	+72 lines, -111 lines	0 comments	Download
M	deps/all.deps/DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	deps/standalone.deps/DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/15371008/diff/2001/dart/runtime/bin/net/nss.gyp File dart/runtime/bin/net/nss.gyp (right): https://codereview.chromium.org/15371008/diff/2001/dart/runtime/bin/net/nss.gyp#newcode5 dart/runtime/bin/net/nss.gyp:5: # Copyright (c) 2013, the Dart project authors. ...

7 years, 7 months ago (2013-05-22 06:39:04 UTC) #2

Bill Hesse

7 years, 7 months ago (2013-05-22 14:41:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r23019 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15371008: dart:io | Roll third_party/nss from Chromium to revision 199075. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages