Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 153653008: Fix analyzer test failure. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analyzer test failure. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
TBR You can be pleasantly surprised. :-)
6 years, 10 months ago (2014-02-12 20:37:38 UTC) #1
Emily Fortuna
Committed patchset #1 manually as r32619 (presubmit successful).
6 years, 10 months ago (2014-02-12 20:37:59 UTC) #2
floitsch
6 years, 10 months ago (2014-02-12 21:37:00 UTC) #3
Message was sent while issue was closed.
LGTM.

Yes. Forgot that we run through the API :)
But the actual tests are not yet checked (I think).

Powered by Google App Engine
This is Rietveld 408576698