Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 153603004: Fixing issues from IDL upgrade (Closed)

Created:
6 years, 10 months ago by blois
Modified:
6 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing issues from IDL upgrade * CustomElement update to match new Element syntax fixes analyzer issue * Document.createTreeWalker/createNodeIterator change to pass in last argument for IE11. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=32513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +14 lines, -13 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 10 months ago (2014-02-10 19:39:27 UTC) #1
blois
Committed patchset #1 manually as r32513 (presubmit successful).
6 years, 10 months ago (2014-02-10 19:39:58 UTC) #2
vsm
6 years, 10 months ago (2014-02-10 19:58:15 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698