Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 15359010: Make VM debugger stop at every safe point (Closed)

Created:
7 years, 7 months ago by hausner
Modified:
7 years, 7 months ago
Reviewers:
devoncarew, Ivan Posva
CC:
reviews_dartlang.org, devoncarew, podivilov1
Visibility:
Public.

Description

Make VM debugger stop at every safe point Debugger front-end can decide to ignore some steps and only halt when the next line is reached. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22972

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -37 lines) Patch
M runtime/vm/debugger.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/debugger.cc View 1 4 chunks +13 lines, -29 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
Devon, Pavel, you can use these diffs to check your changes to the debugger front-end.
7 years, 7 months ago (2013-05-20 21:01:53 UTC) #1
Ivan Posva
LGTM -ip
7 years, 7 months ago (2013-05-20 21:06:06 UTC) #2
devoncarew
FYI, the corresponding editor change has landed.
7 years, 7 months ago (2013-05-21 22:56:49 UTC) #3
hausner
7 years, 7 months ago (2013-05-21 23:07:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698