Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 15356003: - Extend the coin test for slightly different scenarios. (Closed)

Created:
7 years, 7 months ago by Ivan Posva
Modified:
7 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Extend the coin test for slightly different scenarios. - Crank the generator a couple of times before returning a newly allocated one. Committed: https://code.google.com/p/dart/source/detail?r=23309

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -31 lines) Patch
M runtime/lib/math_patch.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M tests/lib/math/coin_test.dart View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M tests/lib/math/random_test.dart View 1 2 1 chunk +30 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 7 months ago (2013-05-21 20:48:19 UTC) #1
srdjan
Waiting on synced up sources
7 years, 7 months ago (2013-05-28 08:21:46 UTC) #2
Ivan Posva
7 years, 6 months ago (2013-05-28 22:15:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698