Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 153553009: Implement Isolate.pause in dart2js. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, siva
Visibility:
Public.

Description

Implement Isolate.pause in dart2js. This is a trivial implementation of Isolate.pause. It introduces out-of-band control messages to the control port int a simple way (if receiveport == controlport treat specially). Control port is now created for each isolate, along with a Capability allowing pausing. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32485

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -23 lines) Patch
sdk/lib/_internal/lib/isolate_helper.dart View 12 chunks +84 lines, -18 lines 0 comments Download
sdk/lib/_internal/lib/isolate_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
tests/isolate/isolate.status View 1 1 chunk +2 lines, -2 lines 0 comments Download
tests/isolate/pause_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
Feel free to add more reviewers. Siva: Do you see any problems in implementing similar ...
6 years, 10 months ago (2014-02-07 13:52:00 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dart File tests/isolate/pause_test.dart (right): https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dart#newcode35 tests/isolate/pause_test.dart:35: return new Future.delayed(const Duration(milliseconds: /*25*/0)); on purpose? https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dart#newcode39 ...
6 years, 10 months ago (2014-02-07 15:40:16 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #2 manually as r32485 (presubmit successful).
6 years, 10 months ago (2014-02-10 08:33:21 UTC) #3
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-02-10 08:41:26 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dart
File tests/isolate/pause_test.dart (right):

https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dar...
tests/isolate/pause_test.dart:35: return new Future.delayed(const
Duration(milliseconds: /*25*/0));
To make it run in d8 while testing.
Will remove now, and mark as failng in d8.

https://codereview.chromium.org/153553009/diff/1/tests/isolate/pause_test.dar...
tests/isolate/pause_test.dart:39: print("Success");
On 2014/02/07 15:40:16, floitsch wrote:
> debug?

Done.

Powered by Google App Engine
This is Rietveld 408576698