Issue 153553007: Add mirrors_reader_test.

Issue 153553007: Add mirrors_reader_test. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
rmacnak, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add mirrors_reader_test which tests that everything reachable from a [MirrorSystem] can be accessed. BUG= R=floitsch@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=32415

Patch Set 2 : Improve handling of assertion failures. #

Patch Set 3 : Small fix. #

Total comments: 4

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+572 lines, -8 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/source_mirrors.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	tests/compiler/dart2js/mirrors/mirrors_reader_test.dart	View	1 2	1 chunk	+141 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors/mirrors_test_helper.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View		2 chunks	+4 lines, -0 lines	2 comments	Download
A	tests/lib/mirrors/mirrors_reader.dart	View	1 2	1 chunk	+262 lines, -0 lines	2 comments	Download
A	tests/lib/mirrors/mirrors_reader_test.dart	View	1 2	1 chunk	+53 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/mirrors_visitor.dart	View		1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/153553007/diff/1/tests/lib/mirrors/mirrors_reader.dart File tests/lib/mirrors/mirrors_reader.dart (right): https://codereview.chromium.org/153553007/diff/1/tests/lib/mirrors/mirrors_reader.dart#newcode54 tests/lib/mirrors/mirrors_reader.dart:54: // Visit the declation once. declaration

6 years, 10 months ago (2014-02-06 15:09:06 UTC) #2

rmacnak

LGTM https://codereview.chromium.org/153553007/diff/170001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/153553007/diff/170001/tests/lib/lib.status#newcode232 tests/lib/lib.status:232: mirrors/mirrors_reader_test: RuntimeError # Issue 16588 This will probably ...

6 years, 10 months ago (2014-02-06 18:19:21 UTC) #3

Johnni Winther

Committed patchset #3 manually as r32415 (presubmit successful).

6 years, 10 months ago (2014-02-07 09:26:41 UTC) #4

Johnni Winther

6 years, 10 months ago (2014-02-07 10:00:56 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/153553007/diff/170001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/153553007/diff/170001/tests/lib/lib.status#ne...
tests/lib/lib.status:232: mirrors/mirrors_reader_test: RuntimeError # Issue
16588
On 2014/02/06 18:19:21, Ryan Macnak wrote:
> This will probably timeout on debug Dartium.

It was!

https://codereview.chromium.org/153553007/diff/170001/tests/lib/mirrors/mirro...
File tests/lib/mirrors/mirrors_reader.dart (right):

https://codereview.chromium.org/153553007/diff/170001/tests/lib/mirrors/mirro...
tests/lib/mirrors/mirrors_reader.dart:127: } else if (value is Iterable) {
On 2014/02/06 18:19:21, Ryan Macnak wrote:
> I think we should merge in the immutable_collections_test and assert lists and
> maps are immutable here.

Added a TODO.

Expand Messages | Collapse Messages