Issue 15353002: Add a call to CheckIsolateState in all paths of Dart_GetField and Dart_SetField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15353002: Add a call to CheckIsolateState in all paths of Dart_GetField and Dart_SetField. (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
Mads Ager (google), Mads Ager (chromium)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Add a call to CheckIsolateState in all paths of Dart_GetField and Dart_SetField. R=ager@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=22893

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -10 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	4 chunks	+11 lines, -9 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mads Ager (chromium)

LGTM Is it possible to add a regression test?

7 years, 7 months ago (2013-05-18 06:03:20 UTC) #2

siva

Added regression test to check for GetField/SetField calls right after loading the script.

7 years, 7 months ago (2013-05-20 15:55:45 UTC) #3

siva

7 years, 7 months ago (2013-05-20 16:02:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22893 (presubmit successful).