Issue 15339002: Reuse _isOneByteWhitespace in all the classes for implementing _isWhitespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15339002: Reuse _isOneByteWhitespace in all the classes for implementing _isWhitespace. (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reuse _isOneByteWhitespace in all the classes for implementing _isWhitespace. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22882

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -21 lines)			Patch
	M	runtime/lib/string_patch.dart	View		5 chunks	+15 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2013/05/17 21:13:07, siva wrote: You may want to synchronize your CL with Florian's: https://codereview.chromium.org/15333006/

7 years, 7 months ago (2013-05-17 23:20:46 UTC) #2

siva

Committed patchset #1 manually as r22882 (presubmit successful).

7 years, 7 months ago (2013-05-17 23:49:53 UTC) #4

floitsch

7 years, 7 months ago (2013-05-21 11:45:48 UTC) #5

Message was sent while issue was closed.

On 2013/05/17 23:20:46, srdjan wrote:
> On 2013/05/17 21:13:07, siva wrote:
> 
> You may want to synchronize your CL with Florian's:
> 
> https://codereview.chromium.org/15333006/

Yes.
It would have been easier if I had just moved the functions myself (in my CL)
instead of going through a conflicting merge with trunk.
Note: the actual CL was https://codereview.chromium.org/15348003/

Expand Messages | Collapse Messages