Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 15338008: - Add a GetClassId() to Object, so that we do not have to (Closed)

Created:
7 years, 7 months ago by Ivan Posva
Modified:
7 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Add a GetClassId() to Object, so that we do not have to create a temporary class handle only to get at an object's class id, which is stored in the object header. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M runtime/lib/object.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 7 months ago (2013-05-20 20:43:55 UTC) #1
siva
lgtm
7 years, 7 months ago (2013-05-20 21:00:34 UTC) #2
Ivan Posva
7 years, 7 months ago (2013-05-20 21:01:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698