Issue 15337005: Ensure to close file-stream on all errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15337005: Ensure to close file-stream on all errors. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure to close file-stream on all errors. BUG= Committed: https://code.google.com/p/dart/source/detail?r=22932

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	sdk/lib/io/file_impl.dart	View		3 chunks	+13 lines, -6 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r22932 (presubmit successful).

7 years, 7 months ago (2013-05-21 11:11:57 UTC) #3

kustermann

lgtm https://codereview.chromium.org/15337005/diff/1/sdk/lib/io/file_impl.dart File sdk/lib/io/file_impl.dart (right): https://codereview.chromium.org/15337005/diff/1/sdk/lib/io/file_impl.dart#newcode81 sdk/lib/io/file_impl.dart:81: _closeFile().then((_) { _controller.close(); }); I don't know if ...

7 years, 7 months ago (2013-05-21 11:23:57 UTC) #4

Anders Johnsen

7 years, 7 months ago (2013-05-21 11:37:27 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15337005/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/15337005/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:81: _closeFile().then((_) { _controller.close(); });
On 2013/05/21 11:23:57, kustermann wrote:
> I don't know if the Future returned by '_closeFile()' can complete with an
> error?

I'm quite sure it can't. Can't come to think of any scenario at least.

Expand Messages | Collapse Messages