Issue 153183002: Do not generate code to create a CallStack in the ConsoleBase calls as that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153183002: Do not generate code to create a CallStack in the ConsoleBase calls as that (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 10 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not generate code to create a CallStack in the ConsoleBase calls as that variable is not used at all. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=32265

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	tools/dom/scripts/systemnative.py	View		2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Jacob

LGTM Can you file a bug to make the script location for console log messages ...

6 years, 10 months ago (2014-02-03 22:22:57 UTC) #2

siva

6 years, 10 months ago (2014-02-03 22:47:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r32265 (presubmit successful).