Issue 15316011: Report MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS and other redirection related.

Issue 15316011: Report MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS and other redirection related. (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS and other redirection related. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22899

Patch Set 2 : Fixes for review comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -9 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	3 chunks	+17 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	4 chunks	+49 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	3 chunks	+61 lines, -1 line	0 comments	Download
M	tests/co19/co19-analyzer.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode395 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:395: FIELD_INITIALIZING_FORMAL_REDIRECTING_CONSTRUCTOR( The distinction between these two error messages ...

7 years, 7 months ago (2013-05-20 17:18:59 UTC) #2

jwren

On 2013/05/20 17:18:59, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java > File > editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java ...

7 years, 7 months ago (2013-05-20 17:47:18 UTC) #3

scheglov

Committed patchset #2 manually as r22899 (presubmit successful).

7 years, 7 months ago (2013-05-20 19:49:50 UTC) #4

scheglov

7 years, 7 months ago (2013-05-20 19:50:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
(right):

https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:395:
FIELD_INITIALIZING_FORMAL_REDIRECTING_CONSTRUCTOR(
On 2013/05/20 17:18:59, Brian Wilkerson wrote:
> The distinction between these two error messages is not very clear. I'm
> concerned that users won't understand what they mean. Not sure how to make it
> better, though.

OK, I will leave only one.

https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/15316011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2457:
for (ConstructorInitializer initializer : node.getInitializers()) {
On 2013/05/20 17:18:59, Brian Wilkerson wrote:
> It would be slightly more efficient to merge these two loops.

Done.

Expand Messages | Collapse Messages