Issue 1531083002: Fix the toJson/fromJson test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1531083002: Fix the toJson/fromJson test. (Closed)

Created:
5 years ago by nweiz

Modified:
5 years ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/oauth2.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the toJson/fromJson test. DateTime has begun storing sub-millisecond times, which means that storing and retrieving the milliseconds since the epoch no longer produces an identical object. This rounds the test value to avoid this failure. R=kevmoo@google.com Committed: https://github.com/dart-lang/oauth2/commit/a4541ee9b1ac8eb1b8c0f111d402e8e71674fb65

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/credentials_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

5 years ago (2015-12-16 22:37:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4541ee9b1ac8eb1b8c0f111d402e8e71674fb65 (presubmit successful).