Issue 153103004: Add a UpdatedGuardedCidBit to Class object so that we don't have

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153103004: Add a UpdatedGuardedCidBit to Class object so that we don't have (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a UpdatedGuardedCidBit to Class object so that we don't have to iterate over all the classes and it's fields to update the GuardedCid value on each call to Dart_Allocate. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32271

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -12 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2	1 chunk	+16 lines, -12 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	3 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://chromiumcodereview.appspot.com/153103004/diff/40001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/153103004/diff/40001/runtime/vm/dart_api_impl.cc#newcode3062 runtime/vm/dart_api_impl.cc:3062: if (!cls.is_updated_guarded_cid()) { Change the name as discussed ...

6 years, 10 months ago (2014-02-04 00:36:55 UTC) #2

siva

https://chromiumcodereview.appspot.com/153103004/diff/40001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/153103004/diff/40001/runtime/vm/dart_api_impl.cc#newcode3062 runtime/vm/dart_api_impl.cc:3062: if (!cls.is_updated_guarded_cid()) { On 2014/02/04 00:36:55, srdjan wrote: > ...

6 years, 10 months ago (2014-02-04 00:52:25 UTC) #3

siva

6 years, 10 months ago (2014-02-04 01:12:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32271 (presubmit successful).

Expand Messages | Collapse Messages