Issue 153063003: regenerate fixed custom_elements polyfill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153063003: regenerate fixed custom_elements polyfill (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly

Modified:
6 years, 10 months ago

Reviewers:
floitsch, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

regenerate fixed custom_elements polyfill fixes an issue in the previous package, it was missing MutationObservers which it expects included in the binary generated by Grunt. This did not happen because the sources are pulled in from a relative path, rather than being included in the repository, and there was unfortunately no error issued. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32263

Patch Set 1 #

Patch Set 2 : update pubspec, revision info #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+557 lines, -34 lines)			Patch
A	pkg/custom_element/REVISION	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.debug.js	View		6 chunks	+551 lines, -9 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/custom_element/lib/polyfill.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/custom_element/pubspec.yaml	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/html/html.status	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	tests/html/utils.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

this was issue https://code.google.com/p/dart/issues/detail?id=16441

6 years, 10 months ago (2014-02-03 20:52:38 UTC) #2

Jennifer Messerly

6 years, 10 months ago (2014-02-03 21:52:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32263 (presubmit successful).

Expand Messages | Collapse Messages