Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 15299002: Reapply "Enable full type-checks in checked mode." (Closed)

Created:
7 years, 7 months ago by karlklose
Modified:
7 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Enable full type-checks in checked mode." R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=22846

Patch Set 1 #

Patch Set 2 : Update test expectations. #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -143 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 6 chunks +51 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 5 chunks +37 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_rti.dart View 5 chunks +27 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 12 chunks +93 lines, -43 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +69 lines, -63 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 3 chunks +19 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 7 chunks +4 lines, -10 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
And another try...
7 years, 7 months ago (2013-05-17 11:38:21 UTC) #1
ngeoffray
LGTM! https://codereview.chromium.org/15299002/diff/2001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/15299002/diff/2001/tests/corelib/corelib.status#newcode8 tests/corelib/corelib.status:8: list_test: Fail # dartbug.com/10708 Fail, OK ?
7 years, 7 months ago (2013-05-17 11:44:03 UTC) #2
karlklose
7 years, 7 months ago (2013-05-17 11:46:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698