Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 15298004: Use dart:crypto's Base64 methods in dart:io. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use dart:crypto's Base64 methods in dart:io. BUG=https://code.google.com/p/dart/issues/detail?id=9927 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -183 lines) Patch
D sdk/lib/io/base64.dart View 1 chunk +0 lines, -106 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/websocket_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download
D tests/standalone/crypto/base64_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-17 12:46:44 UTC) #1
Søren Gjesse
lgtm
7 years, 7 months ago (2013-05-17 14:24:24 UTC) #2
Anders Johnsen
7 years, 7 months ago (2013-05-18 09:13:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698