Issue 15295014: Always send kill signal to debug target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15295014: Always send kill signal to debug target (Closed)

Created:
7 years, 7 months ago by hausner

Modified:
7 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, kustermann, ricow1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Always send kill signal to debug target Make sure we kill the debug target process in all cases to ensure that no zombie processes linger around. Also make sure the cleanup code gets only called once. Committed: https://code.google.com/p/dart/source/detail?r=22866 TBR=iposva

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -35 lines)			Patch
	M	tests/standalone/debugger/debug_lib.dart	View		10 chunks	+32 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r22866 (presubmit successful).

7 years, 7 months ago (2013-05-17 18:37:31 UTC) #2

Message was sent while issue was closed.

LGTM -ip

Expand Messages | Collapse Messages