Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 15293005: Add '-static' to ldflags when target architecture is ARM. (Closed)

Created:
7 years, 7 months ago by kustermann
Modified:
7 years, 7 months ago
Reviewers:
zra, siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add '-static' to ldflags when target architecture is ARM. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22916

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gyp/configurations_make.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kustermann
7 years, 7 months ago (2013-05-17 15:50:48 UTC) #1
zra
https://codereview.chromium.org/15293005/diff/1/tools/gyp/configurations.gypi File tools/gyp/configurations.gypi (right): https://codereview.chromium.org/15293005/diff/1/tools/gyp/configurations.gypi#newcode60 tools/gyp/configurations.gypi:60: 'ldflags': ['-static'], I think we'll only be cross-compiling on ...
7 years, 7 months ago (2013-05-17 15:56:37 UTC) #2
kustermann
https://codereview.chromium.org/15293005/diff/1/tools/gyp/configurations.gypi File tools/gyp/configurations.gypi (right): https://codereview.chromium.org/15293005/diff/1/tools/gyp/configurations.gypi#newcode60 tools/gyp/configurations.gypi:60: 'ldflags': ['-static'], On 2013/05/17 15:56:37, zra wrote: > I ...
7 years, 7 months ago (2013-05-17 16:05:33 UTC) #3
Ivan Posva
Should we consider making all Linux binaries static? -Ivan
7 years, 7 months ago (2013-05-17 16:12:51 UTC) #4
kustermann
On 2013/05/17 16:12:51, Ivan Posva wrote: > Should we consider making all Linux binaries static? ...
7 years, 7 months ago (2013-05-17 17:17:16 UTC) #5
siva
Sure go ahead and add the static flag to the ARM ld configuration for now.
7 years, 7 months ago (2013-05-17 17:38:49 UTC) #6
zra
lgtm
7 years, 7 months ago (2013-05-17 17:53:17 UTC) #7
kustermann
Committed patchset #2 manually as r22916 (presubmit successful).
7 years, 7 months ago (2013-05-21 07:15:36 UTC) #8
kustermann
7 years, 7 months ago (2013-05-21 07:16:20 UTC) #9
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698