Issue 152883003: Remove DEBUG ifdefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152883003: Remove DEBUG ifdefs. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove DEBUG ifdefs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32423

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	runtime/bin/file_system_watcher_macos.cc	View		6 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r32423 (presubmit successful).

6 years, 10 months ago (2014-02-07 13:18:11 UTC) #3

Cutch

6 years, 10 months ago (2014-02-07 15:24:03 UTC) #5

Message was sent while issue was closed.

On 2014/02/07 14:20:42, Søren Gjesse wrote:
> lgtm, thanks

Hi,

Please use:

Thread::Compare(ThreadId a, ThreadId b) when comparing thread ids.

John

Expand Messages | Collapse Messages