Report ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY and other body-related errors

Report ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY and other body-related errors

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22891

[Brian Wilkerson, 2013-05-20 13:43:09]

LGTM

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java
(right):

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:258:
ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY);
The convention for this class is for each method to test a single way of
generating a single error. Could we remove the body so that only one error is
being tested?

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:583:
public void test_factoryConstructorWithoutBody() throws Exception {
We also have a convention of matching the method name to the error name. Perhaps
this method could be named "test_factoryWithoutBody".

[jwren, 2013-05-20 14:57:56]

On 2013/05/20 13:43:09, Brian Wilkerson wrote:
> LGTM
> 
>
https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
> File
>
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java
> (right):
> 
>
https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
>
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:258:
> ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY);
> The convention for this class is for each method to test a single way of
> generating a single error. Could we remove the body so that only one error is
> being tested?
> 
>
https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
>
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:583:
> public void test_factoryConstructorWithoutBody() throws Exception {
> We also have a convention of matching the method name to the error name.
Perhaps
> this method could be named "test_factoryWithoutBody".

LGTM

[scheglov, 2013-05-20 15:56:57]

Committed patchset #2 manually as r22891 (presubmit successful).

[scheglov, 2013-05-20 15:57:12]

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java
(right):

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:258:
ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY);
On 2013/05/20 13:43:09, Brian Wilkerson wrote:
> The convention for this class is for each method to test a single way of
> generating a single error. Could we remove the body so that only one error is
> being tested?

Done.

https://codereview.chromium.org/15269005/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:583:
public void test_factoryConstructorWithoutBody() throws Exception {
On 2013/05/20 13:43:09, Brian Wilkerson wrote:
> We also have a convention of matching the method name to the error name.
Perhaps
> this method could be named "test_factoryWithoutBody".

Done.