Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 15268004: Add timeouts to HttpClient. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add timeouts to HttpClient. This introduces a per-connection timeout, configurable by setting HttpClient.idleTimeout. This also introduces a per-HttpClient timeout that will close idle connections, if there have been no active connections for 100 ms. BUG=https://code.google.com/p/dart/issues/detail?id=4857 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22920

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -2 lines) Patch
M sdk/lib/io/http.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 7 chunks +55 lines, -2 lines 0 comments Download
A tests/standalone/io/http_client_timeout_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-17 08:21:41 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/15268004/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/15268004/diff/1/sdk/lib/io/http.dart#newcode877 sdk/lib/io/http.dart:877: * Get and set the idle timeout of ...
7 years, 7 months ago (2013-05-21 08:46:02 UTC) #2
Anders Johnsen
https://codereview.chromium.org/15268004/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/15268004/diff/1/sdk/lib/io/http.dart#newcode877 sdk/lib/io/http.dart:877: * Get and set the idle timeout of non-active ...
7 years, 7 months ago (2013-05-21 09:01:09 UTC) #3
Anders Johnsen
7 years, 7 months ago (2013-05-21 09:01:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698