Add Capability implementation to dart2js libraries.

Add Capability implementation to dart2js libraries.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32275

[floitsch, 2014-02-03 13:11:23]

LGTM with comments.

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1085: // Consider patching a "_visit"
into primitives, SendPort and Capability.
Make it a "TODO" ?

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1361: class Capability implements
isolateLib.Capability {
Move into a separate library, and use it with a prefix. Makes it easier to
understand what "Capability" is. Shadowing is hard to see.

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1368: int int32a = JS("int",
"(Math.random() * 0x100000000) >>> 0");
It is generally preferred not to use "JS" outside the js-helper library.
This function even has a nice name...

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1376: JS("void", "#[#] = #", this,
_internalId, nonce);
Why don't you just use a private field?

[Lasse Reichstein Nielsen, 2014-02-03 13:44:00]

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1085: // Consider patching a "_visit"
into primitives, SendPort and Capability.
Or remove it, now that I have planted the idea in your head :)

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1361: class Capability implements
isolateLib.Capability {
Problem is that *this* library needs access to the private _id above.

I could also just change the name to CapabilityImpl.
I could have toString() => "[object Capability]" and runtimeType => Capability
to improve on the hiding, or I could just ignore it and admit that I'm a system
capability.

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1368: int int32a = JS("int",
"(Math.random() * 0x100000000) >>> 0");
Moving to js-helper.

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1376: JS("void", "#[#] = #", this,
_internalId, nonce);
Paranoia? :)

Ok, changing to private field.

[floitsch, 2014-02-03 14:05:04]

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/152633002/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:1361: class Capability implements
isolateLib.Capability {
On 2014/02/03 13:44:00, Lasse Reichstein Nielsen wrote:
> Problem is that *this* library needs access to the private _id above.
> 
> I could also just change the name to CapabilityImpl.
> I could have toString() => "[object Capability]" and runtimeType => Capability
> to improve on the hiding, or I could just ignore it and admit that I'm a
system
> capability.

There are so many cases where we redirect to private classes and don't change
the runtimeType and toString. I would do the same here.

[Lasse Reichstein Nielsen, 2014-02-04 09:30:54]

Committed patchset #5 manually as r32275 (presubmit successful).