Issue 15260002: Report ParserErrorCode.MISSING_IDENTIFIER

Issue 15260002: Report ParserErrorCode.MISSING_IDENTIFIER (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report ParserErrorCode.MISSING_IDENTIFIER Fixes many trivial co19 tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22875

Patch Set 2 : Fixes for review comments #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -157 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java	View	1	3 chunks	+14 lines, -1 line	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java	View	1	15 chunks	+201 lines, -73 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tests/vm/vm.status	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1	4 chunks	+0 lines, -79 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

I don't like the extra noise from having extra errors reported where they are not ...

7 years, 7 months ago (2013-05-17 14:23:56 UTC) #2

scheglov

PTAL https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java (right): https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java#newcode824 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:824: public void test_missingMiltiplicativeOperator() throws Exception { On 2013/05/17 ...

7 years, 7 months ago (2013-05-17 18:13:24 UTC) #3

PTAL

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java
(right):

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:824:
public void test_missingMiltiplicativeOperator() throws Exception {
On 2013/05/17 14:23:56, Brian Wilkerson wrote:
> Perhaps: test_missingIdentifier_afterOperator()

Done.

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:1114:
ParserErrorCode.MISSING_IDENTIFIER);
On 2013/05/17 14:23:56, Brian Wilkerson wrote:
> There shouldn't be a missing identifier error here. We need to fix the parser
so
> that it isn't happening.

Done.

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java
(right):

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java:58:
ParserErrorCode.MISSING_IDENTIFIER);
On 2013/05/17 14:23:56, Brian Wilkerson wrote:
> There shouldn't be a missing identifier error here.

Done.

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java:68:
ParserErrorCode.MISSING_IDENTIFIER);
On 2013/05/17 14:23:56, Brian Wilkerson wrote:
> There should only be one missing identifier error here.

I think from our offline discussion, there should be 2 missing identifiers and
none "unary plus" errors.

https://codereview.chromium.org/15260002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java:112:
ParserErrorCode.MISSING_IDENTIFIER);
On 2013/05/17 14:23:56, Brian Wilkerson wrote:
> There shouldn't be a use of unary plus operator error here.

Done.

Brian Wilkerson

Other than the one major change, LGTM. https://codereview.chromium.org/15260002/diff/6001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/15260002/diff/6001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode3826 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:3826: } else ...

7 years, 7 months ago (2013-05-17 20:54:58 UTC) #4

scheglov

7 years, 7 months ago (2013-05-17 21:38:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22875 (presubmit successful).

Expand Messages | Collapse Messages