First CL for supporting arm cross compilation + testing on dart buildbots

First CL for supporting arm cross compilation + testing on dart buildbots

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22839

[kustermann, 2013-05-17 07:58:13]

https://codereview.chromium.org/15258005/diff/1/tools/bots/cross-vm.py
File tools/bots/cross-vm.py (right):

https://codereview.chromium.org/15258005/diff/1/tools/bots/cross-vm.py#newcode14
tools/bots/cross-vm.py:14: GCS_BUCKET = 'gs://dart-misc'
I'm not sure which bucket we should use.

https://codereview.chromium.org/15258005/diff/1/tools/bots/cross-vm.py#newcode80
tools/bots/cross-vm.py:80: run(test_args + ['--checked'])
These two steps won't work yet, since we don't have a checked-in binary + the
arm binaries we fetch are not statically compiled.

[ricow1, 2013-05-17 08:19:06]

LGTM, nice and simple
I do wonder if we should actually use the actual revision as part of the
name/dir when we save the binary to GCS. This is a good sanity check to make
sure that the revision on the target is actually the same as the compile
revision. You can easily get it from the environment variable BUILDBOT_REVISION.

We should probably prune the bits after a while, say 500 revisions.

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py
File tools/bots/cross-vm.py (right):

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode14
tools/bots/cross-vm.py:14: GCS_BUCKET = 'gs://dart-misc'
dart-cross-compiled-binaries?

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode40
tools/bots/cross-vm.py:40: bot.Clobber()
why do we clobber here?

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode53
tools/bots/cross-vm.py:53: with bot.BuildStep('Upload build tarball'):
I would, in addition to this, actually set the public-read acl on the file, that
way we will allow developers to download the binary

https://codereview.chromium.org/15258005/diff/6/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/15258005/diff/6/tools/utils.py#newcode200
tools/utils.py:200: gsutil = '/b/build/scripts/slave/gsutil'
I am not extremely happy about having buildbot specific stuff in our normal
testing scripts, but since we are already using it in the upload_sdk.py lets
leave this for now

[kustermann, 2013-05-17 09:34:23]

I'll try to land it now.

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py
File tools/bots/cross-vm.py (right):

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode14
tools/bots/cross-vm.py:14: GCS_BUCKET = 'gs://dart-misc'
On 2013/05/17 08:19:07, ricow1 wrote:
> dart-cross-compiled-binaries?

Done.

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode40
tools/bots/cross-vm.py:40: bot.Clobber()
On 2013/05/17 08:19:07, ricow1 wrote:
> why do we clobber here?
We don't clobber, we call a 'bot.clobber()' which checks if the environment
variable 'BUILDBOT_CLOBBER' was set. If so it will introduce a clobber step,
otherwise it will do nothing.

https://codereview.chromium.org/15258005/diff/6/tools/bots/cross-vm.py#newcode53
tools/bots/cross-vm.py:53: with bot.BuildStep('Upload build tarball'):
On 2013/05/17 08:19:07, ricow1 wrote:
> I would, in addition to this, actually set the public-read acl on the file,
that
> way we will allow developers to download the binary

Done.

[kustermann, 2013-05-17 09:35:44]

Committed patchset #3 manually as r22839 (presubmit successful).