Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 15254002: Mark isolate/isolate_stress_test as timing out. (Closed)

Created:
7 years, 7 months ago by ricow1
Modified:
7 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark isolate/isolate_stress_test as timing out. Marking it as slow in r22808 did not help. Committed: https://code.google.com/p/dart/source/detail?r=22829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 7 months ago (2013-05-17 06:07:36 UTC) #1
ricow1
TBR
7 years, 7 months ago (2013-05-17 06:09:04 UTC) #2
ricow1
Committed patchset #1 manually as r22829 (presubmit successful).
7 years, 7 months ago (2013-05-17 06:09:33 UTC) #3
ahe
LGTM This is bad. I was seeing these tests completing just below the timeout limit. ...
7 years, 7 months ago (2013-05-17 06:54:23 UTC) #4
ahe
7 years, 7 months ago (2013-05-17 06:57:18 UTC) #5
Message was sent while issue was closed.
I think this is an issue with test.dart. Notice that the test is only allowed to
run for 30 seconds:

http://build.chromium.org/p/client.dart/builders/dart2js-ff-linux/builds/7438...

But it should be allowed to run much longer with the "slow" status.

Powered by Google App Engine
This is Rietveld 408576698