Adapt gen_snapshot to the recent changes in bootstrap sources loading scheme.

Adapt gen_snapshot to the recent changes in bootstrap sources loading scheme.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22996

[siva, 2013-05-21 16:45:37]

LGTM with one comment.

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:303: // Keep original names for libraries that have
a mapping (e.g. dart:io).
The comment (e.g: dart:io) seems wrong because you are handling that in the next
check.

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:315: return
Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
You probably need a
if (tag == kImportTag) {
  return ....;
}
ASSERT(tag == kSourceTag);
return Dart_Error("...");
}

or atleast an assert
ASSERT(tag == kImportTag); 
here to ensure that you do not return a library if somebody
does
source "dart:builtin";

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:318: return
Builtin::LoadAndCheckLibrary(Builtin::kIOLibrary);
Ditto comment here.

[podivilov, 2013-05-22 08:54:44]

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:303: // Keep original names for libraries that have
a mapping (e.g. dart:io).
On 2013/05/21 16:45:37, siva wrote:
> The comment (e.g: dart:io) seems wrong because you are handling that in the
next
> check.

Done.

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:315: return
Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
On 2013/05/21 16:45:37, siva wrote:
> You probably need a
> if (tag == kImportTag) {
>   return ....;
> }
> ASSERT(tag == kSourceTag);
> return Dart_Error("...");
> }
> 
> or atleast an assert
> ASSERT(tag == kImportTag); 
> here to ensure that you do not return a library if somebody
> does
> source "dart:builtin";

Done.

https://codereview.chromium.org/15250009/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:318: return
Builtin::LoadAndCheckLibrary(Builtin::kIOLibrary);
On 2013/05/21 16:45:37, siva wrote:
> Ditto comment here.

Done.

[podivilov, 2013-05-22 08:56:03]

Committed patchset #2 manually as r22996 (presubmit successful).