Add unit tests for [Entrypoint.packageFiles] in pub.

Add unit tests for [Entrypoint.packageFiles] in pub.

BUG=7391
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22807

[Bob Nystrom, 2013-05-16 18:14:20]

Couple of nits then LGTM. Very nice.

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:243: workingDir:
root.dir).then((files) {
The indentation is a bit wonky here. How about:

return git.run(
    ["ls-files", "--cached", "--others", "exclude-standard", beneath],
    workingDir: root.dir).then((files) {

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
File sdk/lib/_internal/pub/test/package_files_test.dart (right):

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
sdk/lib/_internal/pub/test/package_files_test.dart:24: group('without git', () {
I read this as "without git installed". How about "not in a git repo"?

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
sdk/lib/_internal/pub/test/package_files_test.dart:35: }, 'nulling entrypoint');
Factor the above 8 lines into a separate function and reuse below.

[nweiz, 2013-05-16 18:40:02]

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:243: workingDir:
root.dir).then((files) {
On 2013/05/16 18:14:20, Bob Nystrom wrote:
> The indentation is a bit wonky here. How about:
> 
> return git.run(
>     ["ls-files", "--cached", "--others", "exclude-standard", beneath],
>     workingDir: root.dir).then((files) {

Done.

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
File sdk/lib/_internal/pub/test/package_files_test.dart (right):

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
sdk/lib/_internal/pub/test/package_files_test.dart:24: group('without git', () {
On 2013/05/16 18:14:20, Bob Nystrom wrote:
> I read this as "without git installed". How about "not in a git repo"?

Done.

https://codereview.chromium.org/15213002/diff/1/sdk/lib/_internal/pub/test/pa...
sdk/lib/_internal/pub/test/package_files_test.dart:35: }, 'nulling entrypoint');
On 2013/05/16 18:14:20, Bob Nystrom wrote:
> Factor the above 8 lines into a separate function and reuse below.

Done.

[nweiz, 2013-05-16 18:41:48]

Committed patchset #2 manually as r22807 (presubmit successful).