Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1520863002: Implement support for converting db values to datastore values with db.Query.filter (Closed)

Created:
5 years ago by kustermann
Modified:
5 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/gcloud.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement support for converting db values to datastore values with db.Query.filter Closes #37 R=sgjesse@google.com Committed: https://github.com/dart-lang/gcloud/commit/a7bd666544542e529a5d9d02601b48bb4166f0f1

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -81 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/datastore_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/db/db.dart View 1 chunk +22 lines, -3 lines 0 comments Download
M lib/src/db/model_db.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/db/model_db_impl.dart View 3 chunks +20 lines, -4 lines 0 comments Download
M pubspec.yaml View 2 chunks +3 lines, -3 lines 0 comments Download
M test/db/e2e/db_test_impl.dart View 1 6 chunks +105 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.dart File test/db/e2e/db_test_impl.dart (right): https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.dart#newcode478 test/db/e2e/db_test_impl.dart:478: query, usersSortedNameDescNicknameAsc.length); There is still some flakiness on the ...
5 years ago (2015-12-11 11:08:44 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.dart File test/db/e2e/db_test_impl.dart (right): https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.dart#newcode523 test/db/e2e/db_test_impl.dart:523: var models = await runQueryWithExponentialBackoff(query, fooUsers.length); Long line ...
5 years ago (2015-12-14 07:53:24 UTC) #3
kustermann
Committed patchset #2 (id:20001) manually as a7bd666544542e529a5d9d02601b48bb4166f0f1 (presubmit successful).
5 years ago (2015-12-14 09:28:33 UTC) #5
kustermann
5 years ago (2015-12-14 09:41:16 UTC) #6
Message was sent while issue was closed.
Thanks

https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.dart
File test/db/e2e/db_test_impl.dart (right):

https://codereview.chromium.org/1520863002/diff/1/test/db/e2e/db_test_impl.da...
test/db/e2e/db_test_impl.dart:523: var models = await
runQueryWithExponentialBackoff(query, fooUsers.length);
On 2015/12/14 07:53:24, Søren Gjesse wrote:
> Long line - and a few more below.

Done.

Powered by Google App Engine
This is Rietveld 408576698