Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 151993003: Remove emission of generic type checks. (Closed)

Created:
6 years, 10 months ago by sigurdm
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove emission of generic type checks. As far as I can tell, these are not needed anymore. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sigurdm
6 years, 10 months ago (2014-02-03 09:27:42 UTC) #1
floitsch
If nothing is using them. -> Remove. LGTM.
6 years, 10 months ago (2014-02-03 14:26:51 UTC) #2
floitsch
Please wait for someone to confirm that this is not needed anymore.
6 years, 10 months ago (2014-02-03 14:29:16 UTC) #3
sigurdm
6 years, 10 months ago (2014-02-03 14:29:30 UTC) #4
sigurdm
6 years, 9 months ago (2014-03-03 09:32:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r33199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698