Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 151833002: Fix issue 16375: disallow marking null-constant types as non-nullable. The issue occurs for strict … (Closed)

Created:
6 years, 10 months ago by srdjan
Modified:
6 years, 10 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

Fix issue 16375: disallow marking null-constant types as non-nullable. The issue occurs for strict equal comparisons, with both inputs being null. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32227

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
runtime/vm/flow_graph_type_propagator.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 10 months ago (2014-02-01 00:31:15 UTC) #1
Ivan Posva
LGTM -ip
6 years, 10 months ago (2014-02-01 00:49:10 UTC) #2
srdjan
6 years, 10 months ago (2014-02-01 00:49:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r32227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698