Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 15174005: Add a bunch of extra logging to Pub. (Closed)

Created:
7 years, 7 months ago by nweiz
Modified:
7 years, 7 months ago
Reviewers:
Bob Nystrom, blois
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Add a bunch of extra logging to Pub. This logging should help clear up the pub test timeouts we've been seeing. Some of it should be removed once we don't need it anymore. TBR Committed: https://code.google.com/p/dart/source/detail?r=22713

Patch Set 1 #

Patch Set 2 : error fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M sdk/lib/_internal/pub/lib/src/hosted_source.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/http.dart View 1 3 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 7 months ago (2013-05-14 22:36:40 UTC) #1
nweiz
I'm going to TBR this so I can get the data I need sooner.
7 years, 7 months ago (2013-05-14 22:41:47 UTC) #2
nweiz
Committed patchset #2 manually as r22713 (presubmit successful).
7 years, 7 months ago (2013-05-14 22:44:07 UTC) #3
Bob Nystrom
7 years, 7 months ago (2013-05-16 16:05:43 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698