Issue 151693002: Fix missing .mirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151693002: Fix missing .mirror. (Closed)

Created:
6 years, 10 months ago by floitsch

Modified:
6 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix missing .mirror. Committed: https://code.google.com/p/dart/source/detail?r=32209

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/docgen/lib/docgen.dart	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r32209 (presubmit successful).

6 years, 10 months ago (2014-01-31 19:02:30 UTC) #2

Johnni Winther

LGTM. Thanks! https://codereview.chromium.org/151693002/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/151693002/diff/1/pkg/docgen/lib/docgen.dart#newcode1583 pkg/docgen/lib/docgen.dart:1583: return dart2js_util.qualifiedNameOf(superclass.mirror); Maybe this should just be ...

6 years, 10 months ago (2014-01-31 19:19:45 UTC) #3

floitsch

6 years, 10 months ago (2014-02-01 02:01:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/151693002/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/151693002/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:1583: return
dart2js_util.qualifiedNameOf(superclass.mirror);
On 2014/01/31 19:19:45, Johnni Winther wrote:
> Maybe this should just be `return superclass.qualifiedName;`.

Seattle (Emily and Alan) agreed to fix this.

Expand Messages | Collapse Messages