Issue 151653002: Fix wrongly recorded uses after polymorphic inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151653002: Fix wrongly recorded uses after polymorphic inlining. (Closed)

Created:
6 years, 10 months ago by Florian Schneider

Modified:
6 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix wrongly recorded uses after polymorphic inlining. When inlining function bodies at a polymorphic site, uses at the callee graph entry need to be removed since this block is removed in the process of inlining. BUG=dartbug.com/16404 TEST=pkgbuild/samples/searchable_list R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32237

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	pkg/pkgbuild.status	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/151653002/diff/1/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/151653002/diff/1/runtime/vm/flow_graph_inliner.cc#newcode1015 runtime/vm/flow_graph_inliner.cc:1015: // the graph anymore. A new target be ...

6 years, 10 months ago (2014-02-01 00:47:36 UTC) #2

Florian Schneider

Committed patchset #1 manually as r32237 (presubmit successful).

6 years, 10 months ago (2014-02-03 09:46:27 UTC) #3

Florian Schneider

6 years, 10 months ago (2014-02-03 09:47:42 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/151653002/diff/1/runtime/vm/flow_graph_inline...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/151653002/diff/1/runtime/vm/flow_graph_inline...
runtime/vm/flow_graph_inliner.cc:1015: // the graph anymore. A new target be
created instead.
On 2014/02/01 00:47:36, srdjan wrote:
> Fix last sentence in the comment.

Oops. Will fix this my next CL.

Expand Messages | Collapse Messages