Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 15162010: Report CTEC.RECURSIVE_CONSTRUCTOR_REDIRECT (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report CTEC.RECURSIVE_CONSTRUCTOR_REDIRECT R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22852

Patch Set 1 #

Patch Set 2 : Non-error test and status file tweaks #

Total comments: 1

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 7 months ago (2013-05-17 01:00:13 UTC) #1
Brian Wilkerson
LGTM. Is it worth adding a non-error test?
7 years, 7 months ago (2013-05-17 14:03:13 UTC) #2
scheglov
Committed patchset #2 manually as r22852 (presubmit successful).
7 years, 7 months ago (2013-05-17 15:35:40 UTC) #3
jwren
7 years, 7 months ago (2013-05-17 18:11:03 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/15162010/diff/4001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
(right):

https://codereview.chromium.org/15162010/diff/4001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:794:
* only action is to invoke another generative constructor.
I think you are missing additional text from the spec.... does it include
information that this is a "compile-time error"?

Powered by Google App Engine
This is Rietveld 408576698