Issue 15145002: Unbox phis with Float32x4 or Uint32x4 type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15145002: Unbox phis with Float32x4 or Uint32x4 type (Closed)

Created:
7 years, 7 months ago by Cutch

Modified:
7 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
	A	tests/lib/typed_data/float32x4_unbox_phi_test.dart	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Vyacheslav Egorov (Google)

Please check that we have tests covering this case (with unboxed phi) LGTM

7 years, 7 months ago (2013-05-13 20:56:38 UTC) #2

Cutch

I've added a test and confirmed by hand that my CL removes the boxing in ...

7 years, 7 months ago (2013-05-13 21:22:32 UTC) #3

Cutch

7 years, 7 months ago (2013-05-14 15:52:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22683 (presubmit successful).