Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 15144004: Implements int to double conversion instructions for MIPS simulator, assembler, disassembler. (Closed)

Created:
7 years, 7 months ago by zra
Modified:
7 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implements int to double conversion instructions for MIPS simulator, assembler, disassembler. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=22763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -1 line) Patch
M runtime/vm/assembler_mips.h View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 7 months ago (2013-05-15 23:20:32 UTC) #1
regis
LGTM
7 years, 7 months ago (2013-05-15 23:36:54 UTC) #2
zra
Committed patchset #1 manually as r22763 (presubmit successful).
7 years, 7 months ago (2013-05-15 23:51:21 UTC) #3
zra
7 years, 7 months ago (2013-05-16 00:00:35 UTC) #4
Message was sent while issue was closed.
On 2013/05/15 23:36:54, regis wrote:
> LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698