Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 15143002: Fix the initialization of PendingCallbacks in scheduled_test. (Closed)

Created:
7 years, 7 months ago by nweiz
Modified:
7 years, 7 months ago
Reviewers:
Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the initialization of PendingCallbacks in scheduled_test. This fixes a case where null was being passed to prefixLines, which also obviates the need for prefixLines to explicitly check for null. R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=22648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/scheduled_test/lib/src/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 7 months ago (2013-05-13 19:25:48 UTC) #1
Andrei Mouravski
Can you give me some context?
7 years, 7 months ago (2013-05-13 19:27:31 UTC) #2
nweiz
On 2013/05/13 19:27:31, Andrei Mouravski wrote: > Can you give me some context? PendingCallback._ takes ...
7 years, 7 months ago (2013-05-13 19:30:44 UTC) #3
Andrei Mouravski
lgtm You should move that context into the review description so it lives in perpetuity.
7 years, 7 months ago (2013-05-13 19:53:07 UTC) #4
nweiz
7 years, 7 months ago (2013-05-13 20:10:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r22648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698