Fix crash with --no-use-cha: the optimizer expects a concrete type for array creation, not dynamic …

Fix crash with --no-use-cha: the optimizer expects a concrete type for array creation, not dynamic as is the result because we cannot determine without CHA if a class is guaranteed to have no sublcasses and has not been implemented. Regardless of use_cha, always rely on known information for internal classes that are not subtype or implemented by other clases.

R=asiva@google.com, vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22655

[Vyacheslav Egorov (Google), 2013-05-13 20:07:29]

lgtm

[siva, 2013-05-13 20:26:28]

https://codereview.chromium.org/15141004/diff/1/runtime/vm/flow_graph_type_pr...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/15141004/diff/1/runtime/vm/flow_graph_type_pr...
runtime/vm/flow_graph_type_propagator.cc:508: case kTypedDataFloat32x4ArrayCid:
This list doesn't seem to be complete and maintaining a list like this could be
cumbersome. Maybe you could modify it the way we discussed offline.

[srdjan, 2013-05-13 22:47:10]

Modified as discussed, Siva could you please take a look.

[Vyacheslav Egorov (Google), 2013-05-13 22:59:53]

Alternatively you could probably just amend CreateArrayInstr::ComputeType to
create a fully specialized CompileType with both cid and type components, as
this is the one that causes the assertion if I understood correctly. 

That would be a local 1 line change.

[siva, 2013-05-13 23:04:00]

lgtm

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:476: // Return true if the class is
private to our intenal libraries (not extendable
internal

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:483: if (library.raw() ==
Library::TypedDataLibrary()) return true;
Do you also want to include MathLibrary() here?

[srdjan, 2013-05-13 23:16:51]

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:476: // Return true if the class is
private to our intenal libraries (not extendable
On 2013/05/13 23:04:00, siva wrote:
> internal

Done.

https://codereview.chromium.org/15141004/diff/6001/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:483: if (library.raw() ==
Library::TypedDataLibrary()) return true;
On 2013/05/13 23:04:00, siva wrote:
> Do you also want to include MathLibrary() here?

Done.

[srdjan, 2013-05-13 23:19:24]

Committed patchset #3 manually as r22655 (presubmit successful).