Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 1509803002: One more simple optimization in isWithin. (Closed)

Created:
5 years ago by Bob Nystrom
Modified:
5 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/path.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

One more simple optimization in isWithin. This makes Konstantine's use case about 11% faster. R=nweiz@google.com Committed: https://github.com/dart-lang/path/commit/94207137d07d44ca0aa0284c4cccbe45c60583bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/context.dart View 11 chunks +22 lines, -25 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
5 years ago (2015-12-08 00:25:25 UTC) #2
nweiz
LGTM I (obviously) wouldn't have guessed that calling codeUnitAt a bunch was faster than using ...
5 years ago (2015-12-09 01:26:49 UTC) #3
Bob Nystrom
5 years ago (2015-12-18 22:16:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94207137d07d44ca0aa0284c4cccbe45c60583bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698