Deal with intercepted fields in the InstanceMirror.getField optimizations.

Deal with intercepted fields in the InstanceMirror.getField optimizations.

R=floitsch@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=32236

[floitsch, 2014-01-31 14:04:48]

LGTM!

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:1029: var body = "(function
probe\$$id(c){return c.$id})";
Maybe add comments explaining the underlying effects of adding the
field/class-name to the probe and the getter.
Otherwise a refactoring might get rid of it.

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:1051: var body = "(function
$className\$$name(o){return i.$name(o)})";
Add comment, explaining that the intercepted getter must not be shared between
multiple instances, since getInterceptor can return the object.
As discussed, this is not a problem here, but if we ever want to share the
getters on a per-class basis it would show up.

[kasperl, 2014-02-03 08:17:44]

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:1029: var body = "(function
probe\$$id(c){return c.$id})";
On 2014/01/31 14:04:49, floitsch wrote:
> Maybe add comments explaining the underlying effects of adding the
> field/class-name to the probe and the getter.
> Otherwise a refactoring might get rid of it.

Done.

https://codereview.chromium.org/150973003/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:1051: var body = "(function
$className\$$name(o){return i.$name(o)})";
On 2014/01/31 14:04:49, floitsch wrote:
> Add comment, explaining that the intercepted getter must not be shared between
> multiple instances, since getInterceptor can return the object.
> As discussed, this is not a problem here, but if we ever want to share the
> getters on a per-class basis it would show up.

Done.

[kasperl, 2014-02-03 08:27:05]

Committed patchset #2 manually as r32236 (presubmit successful).