Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15095009: Report CTEC.CONST_WITH_TYPE_PARAMETERS (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report CTEC.CONST_WITH_TYPE_PARAMETERS R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22651

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 7 months ago (2013-05-13 19:41:05 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/15095009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/15095009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode184 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:184: CONST_WITH_TYPE_PARAMETERS("The constant creation cannot use a type parameter."), ...
7 years, 7 months ago (2013-05-13 19:49:47 UTC) #2
scheglov
7 years, 7 months ago (2013-05-13 20:55:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r22651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698