Report CompileTimeErrorCode.INVALID_REFERENCE_TO_THIS

Report CompileTimeErrorCode.INVALID_REFERENCE_TO_THIS

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22566

[Brian Wilkerson, 2013-05-09 19:41:58]

LGTM

https://codereview.chromium.org/15085012/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/15085012/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1406:
private boolean checkForInvalidReferenceToThis(ThisExpression node) {
Seems like this would be easier to maintain and more efficient if there were a
helper method (perhaps "isThisInInvalidContext") that just walked the parent
chain until it could answer either true, if we should produce an error, or false
if we shouldn't. But I can't think of any cases you've missed.

[jwren, 2013-05-09 20:13:41]

LGTM

[scheglov, 2013-05-09 20:56:42]

https://codereview.chromium.org/15085012/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/15085012/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1406:
private boolean checkForInvalidReferenceToThis(ThisExpression node) {
On 2013/05/09 19:41:58, Brian Wilkerson wrote:
> Seems like this would be easier to maintain and more efficient if there were a
> helper method (perhaps "isThisInInvalidContext") that just walked the parent
> chain until it could answer either true, if we should produce an error, or
false
> if we shouldn't. But I can't think of any cases you've missed.

Done.

[scheglov, 2013-05-09 21:05:06]

Committed patchset #2 manually as r22566 (presubmit successful).