Add the ability to match the contents of a file descriptor against a Matcher.

Add the ability to match the contents of a file descriptor against a Matcher.

R=amouravski@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22539

[Andrei Mouravski, 2013-05-09 00:08:14]

lgtm

1 nit.

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/lib/src/de...
File pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart (right):

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart:26: factory
FileDescriptor.matcher(String name, Matcher matcher) =>
How about some doc comments here?

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
File pkg/scheduled_test/test/descriptor/file_test.dart (right):

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
pkg/scheduled_test/test/descriptor/file_test.dart:186: scheduleSandbox();
Why not pull the schedule into a global group's setUp?

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
pkg/scheduled_test/test/descriptor/file_test.dart:251:
expectTestsPass("binaryMatcherFile().validate() fails if the string contents "
Use ' instead of " here and elsewhere.

[nweiz, 2013-05-09 00:15:12]

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/lib/src/de...
File pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart (right):

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart:26: factory
FileDescriptor.matcher(String name, Matcher matcher) =>
On 2013/05/09 00:08:14, Andrei Mouravski wrote:
> How about some doc comments here?

Done.

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
File pkg/scheduled_test/test/descriptor/file_test.dart (right):

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
pkg/scheduled_test/test/descriptor/file_test.dart:186: scheduleSandbox();
On 2013/05/09 00:08:14, Andrei Mouravski wrote:
> Why not pull the schedule into a global group's setUp?

That doesn't work with metatest. Each call to [expectTestsPass] runs in a new
isolate with a completely clean unittest configuration, which means they can't
share setup code.

https://codereview.chromium.org/15074003/diff/1/pkg/scheduled_test/test/descr...
pkg/scheduled_test/test/descriptor/file_test.dart:251:
expectTestsPass("binaryMatcherFile().validate() fails if the string contents "
On 2013/05/09 00:08:14, Andrei Mouravski wrote:
> Use ' instead of " here and elsewhere.

This needs to be double quotes because it contains an apostrophe. In general,
the style guide doesn't mandate a quote type (or indeed that quotes be
consistent). I think this is correct; it's a big pain to keep all quotes
everywhere consistent, for essentially no benefit.

[nweiz, 2013-05-09 00:16:21]

Committed patchset #2 manually as r22539 (presubmit successful).