Issue 15063006: Report ParserErrorCode.CONSTRUCTOR_WITH_RETURN_TYPE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15063006: Report ParserErrorCode.CONSTRUCTOR_WITH_RETURN_TYPE (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report ParserErrorCode.CONSTRUCTOR_WITH_RETURN_TYPE R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22824

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -10 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java	View	1 chunk	+18 lines, -1 line	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java	View	2 chunks	+16 lines, -8 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

https://codereview.chromium.org/15063006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/15063006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode1609 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:1609: SimpleIdentifier methodName = parseSimpleIdentifier(); This doesn't appear to allow ...

7 years, 7 months ago (2013-05-16 18:03:54 UTC) #2

scheglov

7 years, 7 months ago (2013-05-16 23:13:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22824 (presubmit successful).

Expand Messages | Collapse Messages