Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1505723004: Bump to 0.2.1. (Closed)

Created:
5 years ago by Bob Nystrom
Modified:
5 years ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump to 0.2.1. Also update the script used to validate and bump versions. R=jakemac@google.com Committed: https://github.com/dart-lang/dart_style/commit/e7090213db1a6039e255e2441a3c24813b0214db

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M bin/format.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/chunk_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
M tool/grind.dart View 2 chunks +30 lines, -8 lines 5 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
5 years ago (2015-12-07 20:56:10 UTC) #2
jakemac
lgtm, a couple tiny comments https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart File tool/grind.dart (right): https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart#newcode10 tool/grind.dart:10: final versionPattern = new ...
5 years ago (2015-12-07 22:25:17 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as e7090213db1a6039e255e2441a3c24813b0214db (presubmit successful).
5 years ago (2015-12-07 22:50:34 UTC) #5
Bob Nystrom
Thanks! https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart File tool/grind.dart (right): https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart#newcode10 tool/grind.dart:10: final versionPattern = new RegExp(r"^version: .*$", multiLine: true); ...
5 years ago (2015-12-07 22:50:36 UTC) #6
jakemac
5 years ago (2015-12-07 23:02:54 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart
File tool/grind.dart (right):

https://codereview.chromium.org/1505723004/diff/1/tool/grind.dart#newcode75
tool/grind.dart:75: pubspec = pubspec.replaceAll(versionPattern, "version:
$bumped");
On 2015/12/07 22:50:35, Bob Nystrom wrote:
> On 2015/12/07 22:25:17, jakemac wrote:
> > If the Version class has an explicit getter for the valid version string I
> would
> > use it, otherwise this is probably fine.
> 
> I want to not just match the version string in case some dependency happens to
> coincidentally have the same version as dart_style.

Oh, I wasn't very clear here :). I was just talking about relying on the default
toString() of Version (via `$bumped`). I don't see an explicit getter on the
Version class which gives the formatted version though anyways, so I think you
are fine.

Powered by Google App Engine
This is Rietveld 408576698