Issue 150563005: Short-cut the call to Timer.run, to not go through standalone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150563005: Short-cut the call to Timer.run, to not go through standalone. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
Søren Gjesse, Lasse Reichstein Nielsen, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Short-cut the call to Timer.run, to not go through standalone. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32310

Patch Set 1 #

Total comments: 3

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	runtime/bin/eventhandler.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download
	M	sdk/lib/io/timer_impl.dart	View		3 chunks	+9 lines, -4 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r32310 (presubmit successful).

6 years, 10 months ago (2014-02-05 07:44:15 UTC) #3

Ivan Posva

6 years, 10 months ago (2014-02-05 16:54:46 UTC) #4

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/150563005/diff/1/sdk/lib/io/timer_impl.dart
File sdk/lib/io/timer_impl.dart (right):

https://codereview.chromium.org/150563005/diff/1/sdk/lib/io/timer_impl.dart#n...
sdk/lib/io/timer_impl.dart:210: _lastZeroTimer = _firstZeroTimer = this;
_lastZeroTimer = this;
_firstZeroTimer = this;

The way it is written is not immediately readable as it might also mean:
_lastZeroTimer = _firstZeroTimer == this;
Where the second = was dropped.

https://codereview.chromium.org/150563005/diff/1/sdk/lib/io/timer_impl.dart#n...
sdk/lib/io/timer_impl.dart:260: _firstZeroTimer = _lastZeroTimer = null;
ditto

https://codereview.chromium.org/150563005/diff/1/sdk/lib/io/timer_impl.dart#n...
sdk/lib/io/timer_impl.dart:264: nextTimer = timer = next;
ditto. Here and other places.

Expand Messages | Collapse Messages